GitHub sync enhancement
avatar brianteeman
brianteeman
14 Aug 2014

Steps to reproduce the issue

compare joomla/joomla-cms#3799
with http://issues.joomla.org/tracker/joomla-cms/3799

Expected result

data is the same at both urls

Actual result

issues.j.o is empty

System information (as much as possible)

Additional comments

Is this a broken cron?

avatar brianteeman brianteeman - open - 14 Aug 2014
avatar brianteeman brianteeman - change - 14 Aug 2014
Priority Medium Urgent
avatar mbabker
mbabker - comment - 14 Aug 2014

It actually looks correct with what we're processing right now. We aren't processing commit comments, which is what all the dialog is on that PR. There isn't anything in the opening description, the title matches, and the labels are in sync.

Interestingly enough though, the history says the branch that PR was opened on was deleted but the PR is still open...

avatar brianteeman
brianteeman - comment - 14 Aug 2014

i thought the whole point was that anything entered directly at github was
automatically at jissues and vice versa

On 14 August 2014 13:39, Michael Babker notifications@github.com wrote:

It actually looks correct with what we're processing right now. We aren't
processing commit comments, which is what all the dialog is on that PR.
There isn't anything in the opening description, the title matches, and the
labels are in sync.

Interestingly enough though, the history says the branch that PR was
opened on was deleted but the PR is still open...


Reply to this email directly or view it on GitHub
#417 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar mbabker
mbabker - comment - 14 Aug 2014

I don't remember what we said about pulling over commit comments or if it's been one of those unwritten TODO items that was never implemented. We could do it as long as the webhook is triggered at the right time (looks like the pull_request_review_comment event is what we need to monitor for that, but that also only pulls comments made after the PR is opened).

avatar brianteeman
brianteeman - comment - 14 Aug 2014

the problem right now is that as it stands we still dont have a "single
point of truth" with everything on it.

On 14 August 2014 13:44, Michael Babker notifications@github.com wrote:

I don't remember what we said about pulling over commit comments or if
it's been one of those unwritten TODO items that was never implemented. We
could do it as long as the webhook is triggered at the right time (looks
like the pull_request_review_comment event is what we need to monitor for
that, but that also only pulls comments made after the PR is opened).


Reply to this email directly or view it on GitHub
#417 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 14 Aug 2014

Actually i am confused as I see other issues that do have the comments from
github present on jissues such as
http://issues.joomla.org/tracker/joomla-cms/1132
joomla/joomla-cms#1132

On 14 August 2014 13:45, Brian Teeman brian@teeman.net wrote:

the problem right now is that as it stands we still dont have a "single
point of truth" with everything on it.

On 14 August 2014 13:44, Michael Babker notifications@github.com wrote:

I don't remember what we said about pulling over commit comments or if
it's been one of those unwritten TODO items that was never implemented. We
could do it as long as the webhook is triggered at the right time (looks
like the pull_request_review_comment event is what we need to monitor
for that, but that also only pulls comments made after the PR is opened).


Reply to this email directly or view it on GitHub
#417 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar mbabker
mbabker - comment - 14 Aug 2014

Right. The actual comments on issues/PRs get transferred over automagically. When you comment directly on a commit (on the files changed view when you click to comment specifically on a line, or from a commit view there's a comment form at the bottom of it), that data isn't being synced.

avatar brianteeman
brianteeman - comment - 14 Aug 2014

Ah - I see the subtle difference now

On 14 August 2014 14:19, Michael Babker notifications@github.com wrote:

Right. The actual comments on issues/PRs get transferred over
automagically. When you comment directly on a commit (on the files changed
view when you click to comment specifically on a line, or from a commit
view there's a comment form at the bottom of it), that data isn't being
synced.


Reply to this email directly or view it on GitHub
#417 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar elkuku elkuku - change - 14 Aug 2014
Labels Added: GitHub sync
avatar elkuku elkuku - change - 14 Aug 2014
Labels Added: enhancement
avatar elkuku
elkuku - comment - 14 Aug 2014

I think the idea here is (or was) to maintain the code (and all the related discussion) only on GitHub, while having the "bug discussion" also in our separate tracker.

To have the code discussion also in our tracker I think we would have to fetch the commits and also probably the whole code to our database.
Beside the added information, this would open new possibilities like analyzing the checkstyle result and offer tips to make our sniffers "happy".
We might even think about integrating our good old pull tester to do the work that Travis is currently doing (maybe better but with no doubt more reliable...)

On the other hand I have to confess that I find the change GitHub made recently a bit confusing. Before the change commit comments were displayed along with the piece of code the comment referes to. Currently only a link to the code is displayed.

So, do we want to display commits and commits comments in our tracker?

avatar b2z
b2z - comment - 15 Aug 2014

So, do we want to display commits and commits comments in our tracker?

That's a good question. I think that the tracker should contain only bug related discussions.

avatar roland-d
roland-d - comment - 15 Aug 2014

My preference is not to see commits and commit messages in the bug tracker. They have their place at Github.

avatar b2z b2z - change - 23 Mar 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-03-23 09:58:35
avatar b2z b2z - close - 23 Mar 2015

Add a Comment

Login with GitHub to post a comment