I have tested this item successfully on bf8e351

Tested in localhost with phpmail, sendmail and smtp mail - all worked

I think its a little confusing (or not documented) that the test email is sent to the email address defined in the From email field

This PR has received new commits.

CC: @brianteeman

@brianteeman Thank you for testing it. Yes, this should be documented. Maybe directly in the success message? If yes, could you please send me the correct wording?

how about
+COM_CONFIG_SENDMAIL_SUCCESS="The email was sent successfully to %email. You should check that you've received the test email."

Or even better
+COM_CONFIG_SENDMAIL_SUCCESS="The email was sent successfully to %email using %method. You should check that you've received the test email."

@brianteeman Good idea!

Might be worth changing the email body message as well to show the settings
that were used to send the email

Perhaps
+COM_CONFIG_SENDMAIL_BODY="This is a test mail sent using %method. If you
receive it, then your email settings are correct!"

And even better if it could include all the options for that method

Otherwise when testing and receiving multiple emails you dont know which
method was successfully receieved

On 10 December 2015 at 14:37, Viktor Vogel notifications@github.com wrote:

@brianteeman https://github.com/brianteeman Good idea!

—
Reply to this email directly or view it on GitHub
#8643 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

This PR has received new commits.

CC: @brianteeman

@brianteeman PR updated with your suggestions. Could you please re-test? Thank you!

Completely stopped working now
I have a button but thats all - pressing it doesnt give a success OR a fail
message

On 10 December 2015 at 16:15, Viktor Vogel notifications@github.com wrote:

@brianteeman https://github.com/brianteeman PR updated with your
suggestions. Could you please re-test? Thank you!

—
Reply to this email directly or view it on GitHub
#8643 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Correction - I received the emails with the updated message so it was just in the Joomla admin that I was not getting any messages

@brianteeman I've changed the JavaScript file, so you have first to clear your browser cache.

I have tested this item successfully on 43ba153

I just looked at the code and saw it was using some js - so my last problem was just a JS cache issue
All working well now.

This PR has received new commits.

CC: @brianteeman

Updated screenshot:

This PR has received new commits.

CC: @brianteeman

I have tested this item successfully on a4000f2

Works good!

tested successfully

Switching only to SMTP and not filling any SMTP settings activates the phpmail fallback on clicking the button. The message states "The email was sent successfully to rick@r2h.nl using SMTP. You should check that you've received the test email." But it should give a message that not all SMTP settings are filled ans mail cannot be sent. Also filling all the fields with false date ativates the fallback to phpmail and ther is also no error message.

But it should give a message that not all SMTP settings are filled ans mail cannot be sent. Also filling all the fields with false date ativates the fallback to phpmail and ther is also no error message.

When I put in invalid data I got a failed message

This PR has received new commits.

CC: @brianteeman, @pe7er

I have tested this item successfully on bf5ba5e

I have tested this item successfully on bf5ba5e

Beside that the thing is working, I have the note to

In suggested implementation sendTestMail() totally ignore the form application.xml, this could leed to "false" result (after changes in the form in the future), example sendTestMail say OK but after saving the form validation say FAIL

So my suggestion is to use "common routine" (form filtering and validation) instead of fancy stuff with $app->input in sendTestMail()

Take save.php as example, in Sendtestmail controller, do something like:

$form = $model->getForm();
$validatedData = $model->validate($form, $data);
$result = $model->sendTestMail($validatedData);

To make the form validate only Email params, in the model loadForm need to use $xpath for fieldset[@name="mail"]. So maybe can be need one more method for getEmailForm here or something.

Just suggestion

Setting RTC- would be good to get this in 3.5 and not have to wait a year for 3.6 - there are no b/c issues