@RickR2H The issue is not in the PR but in Travis itself, I will see what I can do about it.

1. I applied the patch and I saw the "Show Site" and the "Show Admin" links in the bottom of the Administrator area (snap1).
2. I went to the Module manager in the Administrator and set the top filter to Administrator
3. I opened the module "User Status" and saw the two new Buttons. They were activated.
4. I turned off and on the "Show view site" and "Show view Administrator" switches and check if both links disappear and reappear in the bottom of the site after saving. (snap2 and snap3).
5. I clicked the "Show Site" and the "Show Admin" links in the bottom of the Administrator area while they were activated. They open a new Site window/ a new Administrator Window.
6. The links worked while editing and article, too.

   ---

   _{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7174.}

@test Succesfully tested and works!

@test
Nice new feature. Tks.
Works OK here.

I can see a small use of a parameter for the "View Site" link. Especially since the code already checks for that (not existing) parameter.

I don't really see the use for a link to open a new admin window. The exact same can be achieved by simply ctrl-clicking the Joomla icon in the top left corner. At least on Windows. On other OS it's likely similar simple.

@Bakual Regarding the language string you've got a point! I'll change it accordingly.

@Bakual The top left click doesn't work when an article is opened!

As a regular web editor I'm coping a lot of article text/code back and forth. When I've opened an article, I have to copy the admin URL and paste it in a new window to open an other article or module. I thought this extra link would make this process a little easier.

@test Works! Nice new feature!

The top left click doesn't work when an article is opened!

I'll give you that. Thus usecase is found.

Setting RTC based on various tests.
Since we are currently in language freeze for 3.4.2, this has to wait or go into 3.5.0. Which may be the same anyway

Nice My first real contribution will be a fact!

Merged into 3.5-dev with 53e6aa9.

Thanks @RickR2H and grats for your first PR
It will be part of Joomla 3.5 and your named will be mentioned in the release announcement

Sorry for commenting on a merged PR. But why add a link to the admin panel? mod_status is an admin module.

@losedk Rick explained a few posts above.

@Bakual Ahh I see, valid argument. But it seems a bit excessive to add yet another link in the footer.

Sorry but this is the wrong place for this change AND/OR the module needs
to be renamed and be given a new description

User Status
Administrator

This module shows the status of the logged-in users.

On 15 June 2015 at 14:06, Peter Lose notifications@github.com wrote:

@Bakual https://github.com/Bakual Ahh I see, valid argument. But it
seems a bit excessive to add yet another link in the footer.

—
Reply to this email directly or view it on GitHub
#7174 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@losedk If it's an issue, we could disable it by default. So nothing changes for anyone. But I guess most probably don't notice at all.

This module shows the status of the logged-in users.

It also showed the link to frontend before this change. So it was already not only about users.
Maybe it's a bit misnamed indeed. The module itself uses mod_status as its code-name.

I know its only a small change but we've been trying to remove stuff from
the core and to make the UI cleaner and simpler.

If we accept every PR because someone has a usecase for it then we will
have the JED inside the core.

In this case it can be achieved either by installing a module or by a
template override.

On 15 June 2015 at 14:19, Thomas Hunziker notifications@github.com wrote:

This module shows the status of the logged-in users.

It also showed the link to frontend before this change. So it was already
not only about users.
Maybe it's a bit misnamed indeed. The module itself uses mod_status as
its code-name.

—
Reply to this email directly or view it on GitHub
#7174 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

I agree that every change has to be carefully considered. The reason why I made the modifications was that it could open a new site window but not a new admin window which seems strange to me. Don't forget the logout link which is also present on the bottom.
In the menu bar the three options, "open a new admin window", "open a new site window" and "logout" are all possible in the standard non-editor interface. The whole top menu is disabled when editing a article/module so we can't access these items. In my humble opinion adding the link to the module and make these three items work in the footer seems a logical step. In the process also added the missing option switches to the module.

Switching all the links off in the footer by default could be a good option for the people who need a cleaner interface.

On 15 Jun 2015 3:18 pm, "Rick Spaan" notifications@github.com wrote:

Switching all the links off in the footer by default could be a good
option for the people who need a cleaner interface.

As is creating a new module available on the JED for those that want the
extra links

—
Reply to this email directly or view it on GitHub.

Net time a I carefully consider creating a PR...

Nobody's trying to suggest that you shouldn't contribute. The reality is for a long time we've accepted a lot of pulls simply because someone took the time to code it and we didn't want to say no. We really need to get to a point where things are being looked at beyond "does it work", which is probably 95% of what influences whether something is determined to be "ready to commit".

Sorry for starting this debate @RickR2H. My intent was not to bash your PR and contribution, it is very appreciated :) I'm merely focused on keeping the UI as clean as possible and I was just a bit puzzled by this being merged so quickly.

@losedk I don't take it personally and I think it is good to have a debate and be critical about whether a change needs to be in the core or not. As a newbie contributor like me it is difficult to decide whether a change is needed or not as there are no direct guidelines. Also with a lot of (cosmetic)changes usability plays an important role but also personal taste. At the end I hope these discussions will make Joomla a better product...!

@RickR2H Great! Hope you will continue to contribute to Joomla and make it even better :)