Feeling Lucky
?
[#6433] - Block instantiation of JDatabaseDriverMysql on PHP 7
- Closed
- 11 May 2015
- Medium
- Build: staging
- # 6433
- Diff
- mbabker:MySQLRemovedInPHP7
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
As of March 4, PHP 7 no longer has the ext/mysql extension. This PR blocks instantiating the driver in this environment by throwing an exception if the PHP major version is 7 or greater (6 is left as allowed since the code is presumably present in the once-upon-a-time-in-development PHP 6 branch).
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Libraries |
mbabker
- comment
- 15 Mar 2015
In our code, we could try catching if the config is set for mysql and use the mysqli driver via JDatabaseDriver::getInstance(), however I'd suggest that should be a separate PR. This one focuses solely on making sure this class cannot be used in PHP 7 as the platform does not support it.
wilsonge
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-11 00:08:48 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
Forgive me if I havent got my head around this correctly but wouldnt it be better (if possible) to have something less destructive
"'This driver is unsupported in PHP 7, using mysqli driver instead.'"
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6433.