[#5120] - Improving query to use indexes better. Fixes #5101
- Closed
- 21 Nov 2014
- Medium
- Build: staging
- # 5120
- Diff
- Hackwar:extensiontable
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
As hinted at in the table, this fixes #5101
enabled seems to only be toggled between 0 and 1, so if we check for everything greater than 1, we only have one value and then we can simply do a comparison. State equally seems to toggle between 0 and 1, although we don't seem to use it at all... This should be investigated further.
jissues-bot
- | Labels |
Added:
?
|
||
Hi @RCheesley, yes, this is mainly a question of code review.
yes, this is mainly a question of code review.
It would be very easy to test if test instructions are present which say where this query is run.
This query is run on every page and every call to Joomla.
zero-24
- | Category | ⇒ | Libraries |
explaining the actual query
and explaining the PRoposed query
as we can see the pr 5120 use index
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-21 06:49:10 |
| Milestone |
Added: |
||
Happy to test but some guidance would be appreciated.
I've got debug enabled, I can see the queries within debug, but I'm not sure what views I should be looking at (I think maybe plugin manager but not sure?) or what I'm looking for pre- and post- patch. It could be that this just needs to be a code inspection and nothing can be 'seen' to be tested, but if so please can you provide clarification.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5120.