[#3470] - Remove useage of "bootstrap_size=1" in sample data
- Closed
- 8 May 2014
- Medium
- Build: staging
- # 3470
- Diff
- Bakual:FixBootstrapSizeSampleData
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Issue
The installation sample data has some modules where the bootstrap_size parameter is set to 1. That doesn't matter currently because the module cromes used in those positions don't use that parameter.
However if you switch the "Module Style" (chrome) in the module advanced tab to html5, then this parameter will be used and you see the funny effect of it. Which makes it obvious that this value is crap and should be removed.
This pictures are taken with the testing samle data when the "Module Style" for the "All Front End Views" module is set to html5:
Buggy "All Front End Views" module:
Expected:
Solution
This PR changes the value of the bootstrap_size from 1 to the default 0.
It only changes the values for new installations. So nothing will break for existing sites.
Affected Modules
blog
- Older Posts
- Image
brochure
- Main Menu
- Login Form
- News Flash
- Footer
- Image
learn
- Top
- Australian Parks
- Latest Park Blogs
- About Parks
- Fruit Shop
- Image Module
- Custom HTML
- Parks Image Module
testing
- Top
- All Frontend Views
- Fruit Shop
Good catch! We had that in the admin area too, fixed for 3.2.0.
Shouldn't bootstrap-size have a default of 12 ?
12/12th is 100% width, same default effect as 0 which should normally not be listed in the corresponding drop-down setting ?
We had that in the admin area too, fixed for 3.2.0.
Yep, I was searching for it but didn't find it anymore 
Shouldn't bootstrap-size have a default of 12 ?
0 or 12 actually do the same thing (use full row). I prefer 0 as an indication of "not set specificially" and it's more consistent with other places. It's also the default value used in the chrome. Thus we could as well just delete the param, it wouldn't matter.
ok 
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-05-08 18:32:59 |
| Labels |
Added:
?
?
?
|
||
Tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33625