[#3462] - [#33623] Improved the cache-key for JController Legacy
- Closed
- 27 Jul 2014
- Medium
- Build: staging
- # 3462
- Diff
- MrBenGriffin:patch-2
- Foreign ID 33623
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
JController’s getView key was way too liberal. when getView had already been used for a view, eg comContent, everything else was ignored and the previous cache entry was being returned.
The revision now uses correct relevant parameters for each view.
Hi @MrBenGriffin
I think it is this JC Tracker:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33623&start=0
Not the #32989 one.
zero - yea, thanks. The tracker 'crashed' (no database 500 error) when I posted 33623 and i used my old reference by mistake.. (I really do try to get things correct!) There is the 'crashed' tracker at #33622
| Title |
|
||||||
| Labels |
Added:
?
?
|
||||||
@test successful
How I tested it - put the code below to com_content/controller display() function:
$config['layout'] = 'default';
var_dump($this->getView('article', 'html', 'ContentView', $config));
$config['layout'] = 'custom';
var_dump($this->getView('article', 'html', 'ContentView', $config));
$config['layout'] = 'default';
var_dump($this->getView('article', 'feed', 'ContentView', $config));
$config['layout'] = 'custom';
var_dump($this->getView('article', 'feed', 'ContentView', $config));
$config['layout'] = 'default';
var_dump($this->getView('article', 'html', 'ContentView', $config));
Notice that in first 4 cases different objects are returned and in 5th case the same object as in 1st case.
Still I am not sure is it B/C or not. Looks like it is 
brianteeman
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-07-27 15:44:11 |
Thanks @MrBenGriffin for contribution.
Joomla issue tracker #32989