[#3450] - [#33617] New option for redirect plugin: Collect URLs
- Closed
- 5 May 2014
- Medium
- Build: staging
- # 3450
- Diff
- Kubik-Rubik:redirect-collect-urls
- Foreign ID 33617
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This pull request makes the collection of URLs optionally. This is useful to avoid unnecessary entries in the database.
JoomlaCode entry: [#33617] New option for redirect plugin: Collect URLs
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33617
tested patch successful with com_patchtester 
Thanks @Kubik-Rubik
| Description | <p>This pull request makes the collection of URLs optionally. This is useful to avoid unnecessary entries in the database.</p> | ⇒ | <p>This pull request makes the collection of URLs optionally. This is useful to avoid unnecessary entries in the database.</p> <p>JoomlaCode entry: [#33617] New option for redirect plugin: Collect URLs</p> <p><a href="http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33617">http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33617</a></p> |
| Labels |
Added:
?
?
|
||
@Kubik-Rubik I like this
| Title |
|
||||||
| Title |
|
||||||
Updated pull request with a notification message in the component for the new option "Collect URLs" in the plugin. The message is only displayed if the plugin is enabled.
This has to wait till after the release of 3.3.0 since it introduces new language strings and we are currently in language freeze mode.
Otherwise I think it looks fine.
This will have to be redone as it fails applying
Also, please alpha order the new language strings.
@infograf768 What exactly fails? Do have an error message? I used the Joomla! CodeSniffer file and the PHP Storm code styling file (by Matt Thomas).
Will reorder the language strings.
Apparently there is a conflct in some files and the PR can't be merged in current stage. You can rebase it to current staging and resolve the conflicts.
@infograf768 Solved conflicts, should be able to be applied.
Merged into 3.4-dev branch since it's a new feature.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-05-05 18:35:34 |
JoomlaCode entry: [#33617] New option for redirect plugin: Collect URLs
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33617